Gentoo Archives: gentoo-dev

From: Alexey Sokolov <alexey+gentoo@××××××××.org>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] linux-info.eclass: getfilevar: pass 'need-compiler=' to make
Date: Tue, 29 Nov 2022 22:27:06
Message-Id: 88d0cc30-cdc5-19a0-cbed-1a0b5487472d@asokolov.org
In Reply to: Re: [gentoo-dev] [PATCH] linux-info.eclass: getfilevar: pass 'need-compiler=' to make by James Le Cuirot
1 29.11.2022 22:14, James Le Cuirot пишет:
2 > On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote:
3 >> This avoids some unnecessary Makefile logic and gives a nice speed up.
4 >>
5 >> Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my
6 >> AMD Phenom II. After, it takes 3 to 4 seconds.
7 >>
8 >> Signed-off-by: Mike Gilbert <floppym@g.o>
9 >> ---
10 >> eclass/linux-info.eclass | 4 +++-
11 >> 1 file changed, 3 insertions(+), 1 deletion(-)
12 >>
13 >> diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
14 >> index fc125b0d751..3e64cb9457a 100644
15 >> --- a/eclass/linux-info.eclass
16 >> +++ b/eclass/linux-info.eclass
17 >> @@ -238,7 +238,9 @@ getfilevar() {
18 >> # Pass dot-config=0 to avoid the config check in kernels prior to 5.4.
19 >> [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; }
20 >> echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \
21 >> - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null
22 >> + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \
23 >> + dot-config=0 need-config= need-compiler= \
24 >> + ${BUILD_FIXES} -s -f - 2>/dev/null
25 >>
26 >> ARCH=${myARCH}
27 >> fi
28 >
29 > I'm confused. Breaking up the line makes it faster?
30
31 It adds need-compiler= which was not there, but yeah, this is somewhat
32 hidden in breaking the line
33
34 --
35 Best regards,
36 Alexey "DarthGandalf" Sokolov