Gentoo Archives: gentoo-dev

From: Michael Palimaka <kensington@g.o>
To: gentoo-dev@l.g.o
Cc: Michael Palimaka <kensington@g.o>
Subject: [gentoo-dev] [PATCH 12/15] cmake-utils.eclass: require two arguments for cmake-utils_use_find_package in EAPI 6 and later
Date: Wed, 20 Jan 2016 10:51:28
Message-Id: 1453286593-26823-13-git-send-email-kensington@gentoo.org
In Reply to: [gentoo-dev] [PATCH 00/15] EAPI 6 support for cmake-utils.eclas by Michael Palimaka
1 This will allow us to remove the capitalisation variants code later.
2 ---
3 eclass/cmake-utils.eclass | 10 ++++++++--
4 1 file changed, 8 insertions(+), 2 deletions(-)
5
6 diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
7 index 51da1c0..960b34b 100644
8 --- a/eclass/cmake-utils.eclass
9 +++ b/eclass/cmake-utils.eclass
10 @@ -295,14 +295,20 @@ cmake-utils_use_with() { _cmake_use_me_now WITH_ "$@" ; }
11 cmake-utils_use_enable() { _cmake_use_me_now ENABLE_ "$@" ; }
12
13 # @FUNCTION: cmake-utils_use_find_package
14 -# @USAGE: <USE flag> [flag name]
15 +# @USAGE: <USE flag> <package name>
16 # @DESCRIPTION:
17 # Based on use_enable. See ebuild(5).
18 #
19 # `cmake-utils_use_find_package foo LibFoo` echoes -DCMAKE_DISABLE_FIND_PACKAGE_LibFoo=OFF
20 # if foo is enabled and -DCMAKE_DISABLE_FIND_PACKAGE_LibFoo=ON if it is disabled.
21 # This can be used to make find_package optional.
22 -cmake-utils_use_find_package() { _cmake_use_me_now_inverted CMAKE_DISABLE_FIND_PACKAGE_ "$@" ; }
23 +cmake-utils_use_find_package() {
24 + if ! has "${EAPI:-0}" 2 3 4 5 && [[ "$#" != 2 ]] ; then
25 + die "Usage: cmake-utils_use_find_package <USE flag> <package name>"
26 + fi
27 +
28 + _cmake_use_me_now_inverted CMAKE_DISABLE_FIND_PACKAGE_ "$@" ;
29 +}
30
31 # @FUNCTION: cmake-utils_use_disable
32 # @USAGE: <USE flag> [flag name]
33 --
34 2.4.10