[gentoo-dev] Re: Changes to toolchain.eclass to better support gnat-gpl ebuild

[Sergei Trofimovich]

On Thu, 2 Apr 2020 12:52:13 +0200
Alfredo Tupone <tupone@g.o> wrote:

> +	# Do not set ADAFLAGS to build the compiler
> +	unset ADAFLAGS

Can you clarify in a comment why it's done?

>  	# Older gcc versions did not detect bash and re-exec itself, so force the
>  	# use of bash.  Newer ones will auto-detect, but this is not harmful.
>  	# This needs to be set for compile as well, as it's used in libtool
>  	# generation, which will break install otherwise (at least in 3.3.6): #664486
>  	CONFIG_SHELL="${EPREFIX}/bin/bash" \
>  	gcc_do_make ${GCC_MAKE_TARGET}

> +	if use ada; then
> +		gcc_do_make "-C gcc gnatlib-shared"
> +		ln -s gcc ../build/prev-gcc || die
> +		ln -s ${CHOST} ../build/prev-${CHOST} || die
> +		gcc_do_make "-C gcc gnattools"
> +	fi

Two points:
1. You probably still need CONFIG_SHELL="${EPREFIX}/bin/bash" passed.
2. Can you add an inline comment why it's needed? Why 'make' does not Just Work?

-- 

  Sergei