Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH vcs-snapshot] Use ${WORKDIR}/${P} rather than ${S} to support ${S} overrides.
Date: Mon, 04 Jun 2012 20:51:38
In Reply to: Re: [gentoo-dev] [PATCH vcs-snapshot] Use ${WORKDIR}/${P} rather than ${S} to support ${S} overrides. by "Michał Górny"
Hash: SHA1

On 06/04/2012 10:06 PM, Michał Górny wrote:
> On Mon, 04 Jun 2012 21:26:00 +0200 hasufell <hasufell@g.o> > wrote: > >> But minetest in sunrise for example which has two different >> repos, one for the engine, one for the data. It's currently split >> in two, but I guess I will merge those soon. > > Why? Is there a good reason to merge two repos into one ebuild? > Does upstream guarantee that the releases will always be synced? > Does it benefit users?
In this case yes. They are released with the exact same tags as you can see in those ebuilds.
> >> It would also enable me to use gtk-youtube-viewer and >> youtube-viewer in one ebuild with vcs-snapshot eclass while >> adding a gtk useflag (currently split too). Otherwise I will have >> to fix it on my own again. > > Once again: does it benefit user? Or just does it imply that > starting or stopping to use gtk part requires user to rebuild the > whole thing?
Eclasses do not benefit any user. They benefit developers. I would simply do similar stuff on my own in the ebuild instead of using vcs-snapshot eclass then.
> >> I find the logic very clear: >> >> SRC="https://my/github/shit -> ${P}.tar.gz" results in >> ${WORKDIR}/${P} and SRC="https://my/github/shit -> >> ${P}-src.tar.gz" results in ${WORKDIR}/${P}-src > > I really don't mind the logic. I'm just aware that it is a little > late to introduce such a destructive change, especially that you > yourself mentioned that it will break existing ebuilds.
So? We fix it.
> > I will be happy to implement it if you can get more approval for > that change. Or else we should consider jumping with the eclass to > -r1 while it isn't widespread too much. >
I don't see the point in bumping it, because it's not widespread. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - iQEcBAEBAgAGBQJPzR7lAAoJEFpvPKfnPDWz5W8H/0Je1mE/Vo7X+46TpuZZyi/3 RJaJMYETeQbbhPM6ACIXtHk629fGCz9Oda7J0YG4LMCYTbxU5MNElZSjbV4aThYD MkSoQlSw/RIBuSEaffWRkAtbmNovHzd+nUyK8cHJTYXffi4CmClPXPPTqGAaRbC/ yJf6JBEfMLK/6ps10eMwf7D/m5ZJUYIPJ1m7DmlUqjpr8R8v2bVbjqB//M9ig7KO yl/W5qzlBa2UAw/Gjgi0ITdDKs5sem7J8+PbVZKED5K0sD10YxZKMImCymJSlFkR gzqZi99qdAs8uhZ1K6h8ozkBLglxkT54IZ8Kn3LWwiQ0/I2xRNgX8Ugt1EQnrQM= =X+fU -----END PGP SIGNATURE-----