| 1 |
On Saturday 07 August 2010 00:21:39 Markos Chandras (hwoarang) wrote: |
| 2 |
> hwoarang 10/08/06 21:21:39 |
| 3 |
> |
| 4 |
> Modified: ChangeLog |
| 5 |
> Added: mlt-0.5.4-r1.ebuild |
| 6 |
> Log: |
| 7 |
> Respect {C,LD}FLAGS when building shared library. Bug #308873 |
| 8 |
> (Portage version: 2.2_rc67/cvs/Linux x86_64) |
| 9 |
|
| 10 |
While fixing bugs can't be bad and I thank you for doing it, I can see a |
| 11 |
couple of important quality problems in this commit: |
| 12 |
|
| 13 |
- There is absolutely no reference to any patch sent upstream and I have not |
| 14 |
seen anything on the upstream dev ml. |
| 15 |
- If you are not in cc of the gentoo bug nor in the herd alias, please cc |
| 16 |
yourself on the bug. |
| 17 |
- Please close the bugs, even the dupes (and apply previous point to the dupes |
| 18 |
too). |
| 19 |
- That way you'll be able to quickly fix (apparently, I didn't check) obvious |
| 20 |
mistakes [1]. |
| 21 |
- You'll have to do a rev. bump for *FLAGS respect, please also check if you |
| 22 |
can avoid it by doing a version bump instead. |
| 23 |
|
| 24 |
|
| 25 |
A. |
| 26 |
|
| 27 |
|
| 28 |
|
| 29 |
[1] https://bugs.gentoo.org/show_bug.cgi?id=332523 |
Archives