Re: [gentoo-dev] Re: gentoo-x86/net-misc/aggregate: aggregate-1.6.ebuild

[Samuli Suominen]

On 10/28/2010 12:30 PM, Fabian Groffen wrote:
> On 28-10-2010 09:25:23 +0000, Samuli Suominen wrote:
>> ssuominen    10/10/28 09:25:23
>>
>> Modified: aggregate-1.6.ebuild
>> Log:
>>   qa
>
> I think it would be good practice if you would give a summary of
> what type of QA you applied, even though for you it may be obvious.
> I just see lots of unnecessary changes that are apparently considered to
> be justified by "QA".

removal of quotes from "${A}", EAPI=2 to get src_configure to put
econf and tc-getCC in, || die to make dobin, rest were unnecessary
cosmetics not worth logging about

so qa/cosmetics, are you really 'complaining' for not mentioning
'cosmetics' in the commitlog?

wont be happening

>
>>   (Portage version: 2.2.0_alpha1/cvs/Linux x86_64)
>>
>> 1.16                 net-misc/aggregate/aggregate-1.6.ebuild
>>
>> Index: aggregate-1.6.ebuild
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/net-misc/aggregate/aggregate-1.6.ebuild,v
>> retrieving revision 1.15
>> retrieving revision 1.16
>> diff -u -r1.15 -r1.16
>> --- aggregate-1.6.ebuild	17 Oct 2010 04:46:37 -0000	1.15
>> +++ aggregate-1.6.ebuild	28 Oct 2010 09:25:23 -0000	1.16
>> @@ -1,26 +1,33 @@
>>  # Copyright 1999-2010 Gentoo Foundation
>>  # Distributed under the terms of the GNU General Public License v2
>> -# $Header: /var/cvsroot/gentoo-x86/net-misc/aggregate/aggregate-1.6.ebuild,v 1.15 2010/10/17 04:46:37 leio Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/net-misc/aggregate/aggregate-1.6.ebuild,v 1.16 2010/10/28 09:25:23 ssuominen Exp $
>>
>> -inherit eutils
>> +EAPI=2
>> +inherit eutils toolchain-funcs
>>
>>  DESCRIPTION="aggregate takes a list of prefixes in conventional format on stdin, and performs two optimisations to reduce the length of the prefix list."
>>  HOMEPAGE="http://dist.automagic.org/"
>>  SRC_URI="${HOMEPAGE}/${P}.tar.gz"
>> +
>>  LICENSE="as-is"
>>  SLOT="0"
>>  KEYWORDS="alpha amd64 hppa ia64 ~mips ppc sparc x86"
>>  IUSE=""
>> -DEPEND=""
>> +
>>  RDEPEND="dev-lang/perl"
>> +DEPEND=""
>>
>> -src_unpack() {
>> -	unpack "${A}"
>> +src_prepare() {
>>  	epatch "${FILESDIR}"/${P}-build-fixup.patch
>>  }
>>
>> +src_configure() {
>> +	tc-export CC
>> +	econf
>> +}
>> +
>>  src_install() {
>> -	dobin aggregate aggregate-ios
>> -	doman aggregate.1 aggregate-ios.1
>> -	dodoc LICENSE HISTORY
>> +	dobin aggregate aggregate-ios || die
>> +	doman aggregate{,-ios}.1
>> +	dodoc HISTORY
>>  }
>>
>>
>>
>