Gentoo Archives: gentoo-dev

From: Alec Warner <antarus@g.o>
To: gentoo-dev@l.g.o
Cc: hkbst@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild
Date: Wed, 26 Sep 2007 05:16:33
Message-Id: b41005390709252205s5da52d86q2c60961a59fbe40c@mail.gmail.com
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild by Donnie Berkholz
1 On 9/24/07, Donnie Berkholz <dberkholz@g.o> wrote:
2 > On 12:35 Mon 24 Sep , Marijn Schouten (hkbst) wrote:
3 > > hkbst 07/09/24 12:35:11
4 > >
5 > > Modified: ChangeLog
6 > > Added: bigloo-3.0b_p2.ebuild
7 > > Log:
8 > > bump 3.0b-2, minor bugfix version
9 > > (Portage version: 2.1.3.9)
10 >
11 > > # "make test" does something weird so default src_test() in /usr/lib/portage/bin/ebuild.sh fails the following test
12 > > # elif emake -j1 test -n &> /dev/null; then
13 > > # so copy straight from default src_test() all the stuff which depends on that test passing
14 > > src_test() {
15 > > vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
16 > > if ! emake -j1 test; then
17 > > hasq test $FEATURES && die "Make test failed. See above for details."
18 > > hasq test $FEATURES || eerror "Make test failed. See above for details."
19 > > fi
20 > > }
21 >
22 > I'm a bit confused about what's going on here. Isn't src_test() only
23 > supposed to run when 'test' is in FEATURES?
24
25 Yes, but this is done python side (not bash side).
26
27 You should not use $FEATURES in an ebuild as they are not meant to be
28 part of the API.
29
30 >
31 > Thanks,
32 > Donnie
33 > --
34 > gentoo-dev@g.o mailing list
35 >
36 >
37 --
38 gentoo-dev@g.o mailing list

Replies