Re: [gentoo-dev] [PATCH 02/44] apache-module.eclass: Set @PROVIDES

[Michał Górny]

On Thu, 2021-09-02 at 08:50 -0400, Michael Orlitzky wrote:
> On Thu, 2021-09-02 at 12:46 +0200, Michał Górny wrote:
> > Signed-off-by: Michał Górny <mgorny@g.o>
> > ---
> >  eclass/apache-module.eclass | 1 +
> >  1 file changed, 1 insertion(+)
> > ...
> >  # @SUPPORTED_EAPIS: 5 6 7
> > +# @PROVIDES: depend.apache
>
> I'm not sure about this one. The depend.apache eclass is junk and we
> should be encouraging people to move away from it (bug 616612):
>
>   * If you want to depend on apache, depend on apache.
>
>   * If you need paths like APACHE_MODULESDIR, the "apxs" tool is now
>     in PATH so you can get it from $(apxs -q libexecdir)
>
>   * If you need paths like APACHE_MODULES_CONFDIR, the eclass doesn't 
>     work anyway. You can hard-code those paths yourself (relative to
>     apxs -q sysconfdir), or if anyone feels up to the task, they could
>     write a greatly simplified apache-paths.eclass that provides these
>     paths via functions that are to be called outside of global scope.
>
> If people are using anything in depend.apache, I think a warning is
> appropriate. Making a promise that apache-module (which is not junk)
> provides depend.apache will moreover make it harder to disentangle them
> in the future if anyone decides to fix things.
>

Apparently, need_apache* is the problem.  Most of the ebuilds in www-
apache/* are calling it:

libapreq2/libapreq2-2.15-r1.ebuild:need_apache2
libapreq2/libapreq2-2.16.ebuild:need_apache2
mod_auth_kerb/mod_auth_kerb-5.4-r2.ebuild:need_apache2
mod_auth_radius/mod_auth_radius-1.5.8.ebuild:need_apache2
mod_auth_tkt/mod_auth_tkt-2.1.0-r1.ebuild:need_apache2
mod_authnz_external/mod_authnz_external-3.3.2.ebuild:need_apache2_4
...

Ofc, I'm fine with leaving it as-is, i.e. assuming they all need to
inherit depend.apache explicitly.

-- 
Best regards,
Michał Górny