Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/2] git-r3.eclass: Update docs to discourage unsafe protocols
Date: Sun, 20 Aug 2017 19:25:35
Message-Id: 1503257124.20666.1.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 1/2] git-r3.eclass: Update docs to discourage unsafe protocols by William Hubbs
1 W dniu nie, 20.08.2017 o godzinie 13∶05 -0500, użytkownik William Hubbs
2 napisał:
3 > On Sat, Aug 19, 2017 at 10:25:01AM +0200, Michał Górny wrote:
4 > > ---
5 > > eclass/git-r3.eclass | 14 +++++++++-----
6 > > 1 file changed, 9 insertions(+), 5 deletions(-)
7 > >
8 > > diff --git a/eclass/git-r3.eclass b/eclass/git-r3.eclass
9 > > index bc7d4d920299..42b586811368 100644
10 > > --- a/eclass/git-r3.eclass
11 > > +++ b/eclass/git-r3.eclass
12 > > @@ -105,10 +105,14 @@ fi
13 > > # @ECLASS-VARIABLE: EGIT_REPO_URI
14 > > # @REQUIRED
15 > > # @DESCRIPTION:
16 > > -# URIs to the repository, e.g. git://foo, https://foo. If multiple URIs
17 > > -# are provided, the eclass will consider them as fallback URIs to try
18 > > -# if the first URI does not work. For supported URI syntaxes, read up
19 > > -# the manpage for git-clone(1).
20 > > +# URIs to the repository, e.g. https://foo. If multiple URIs are
21 > > +# provided, the eclass will consider the remaining URIs as fallbacks
22 > > +# to try if the first URI does not work. For supported URI syntaxes,
23 > > +# read up the manpage for git-clone(1).
24 >
25 > s/read up/read/
26 >
27 > > +# URIs should be using https:// whenever possible. http:// and git://
28 > > +# URIs are unsafe and their use (even if only as a fallback) makes
29 > > +# MITM attacks possible.
30 > > #
31 > > # It can be overriden via env using ${PN}_LIVE_REPO variable.
32 >
33 > s/overriden/overridden/
34 >
35
36 Fixed, thanks.
37
38 --
39 Best regards,
40 Michał Górny