Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Anna Vyalkova <cyber+gentoo@×××××.in>
Cc: gentoo-dev@l.g.o, vim@g.o
Subject: Re: [gentoo-dev] [PATCH v5.5] vim-plugin.eclass: EAPI 8: add src_prepare
Date: Thu, 14 Apr 2022 05:10:20
Message-Id: ur160uu6t@gentoo.org
In Reply to: [gentoo-dev] [PATCH v5.5] vim-plugin.eclass: EAPI 8: add src_prepare by Anna Vyalkova
1 >>>>> On Thu, 14 Apr 2022, Anna Vyalkova wrote:
2
3 > +fi
4 > +
5 > +EXPORT_FUNCTIONS src_install pkg_postinst pkg_postrm
6 > +
7 > +# src_prepare is only exported in EAPI >= 8
8 > +case ${EAPI} in
9 > + 6|7) ;;
10 > + *) EXPORT_FUNCTIONS src_prepare ;;
11 > +esac
12 > +
13 > +if [[ ! ${_VIM_PLUGIN_ECLASS} ]]; then
14
15 > [...]
16
17 > -EXPORT_FUNCTIONS src_install pkg_postinst pkg_postrm
18
19 What is the rationale for moving EXPORT_FUNCTIONS? The standard nowadays
20 is to have it at the end of the eclass (so it's immediately clear that
21 inherit order will be as expected).
22
23 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature