[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: media-sound/qmmp/

[hasufell]

On 10/10/2015 12:52 PM, Markos Chandras wrote:
> commit:     7afe3acf2ff141d2940f2e02b6e232331d93f68e
> Author:     Markos Chandras <hwoarang <AT> gentoo <DOT> org>
> AuthorDate: Sat Oct 10 10:51:13 2015 +0000
> Commit:     Markos Chandras <hwoarang <AT> gentoo <DOT> org>
> CommitDate: Sat Oct 10 10:51:37 2015 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7afe3acf
>
> media-sound/qmmp: Version bumps for Qt4 and Qt4 releases
>
> Drop ppc from qmmp-1.0.0(Qt5) because they don't have
> Qt5 keywords
>

[...]

> diff --git a/media-sound/qmmp/qmmp-0.9.2.ebuild b/media-sound/qmmp/qmmp-0.9.2.ebuild
> new file mode 100644
> index 0000000..5f82a4d
> --- /dev/null
> +++ b/media-sound/qmmp/qmmp-0.9.2.ebuild

[...]

> +
> +src_prepare() {
> +	if has_version dev-libs/libcdio-paranoia; then
> +		sed -i \
> +			-e 's:cdio/cdda.h:cdio/paranoia/cdda.h:' \
> +			src/plugins/Input/cdaudio/decoder_cdaudio.cpp || die
> +	fi

This looks really weird. A conditional sed on what package is installed
on the users system? Can you elaborate?

> +
> +	cmake-utils_src_prepare
> +}
> +
> +src_configure() {
> +	mycmakeargs=(

It doesn't hurt to make this a local variable.

> +		$(cmake-utils_use_use alsa)
> +		$(cmake-utils_use_use aac)
> +		$(cmake-utils_use_use alsa)

[...]