Gentoo Archives: gentoo-dev

From: Eric Olinger <EvvL@××××××××××.net>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Release: metadata.xml python module
Date: Tue, 29 Jun 2004 17:22:14
Message-Id: 20040629102141.0000024c@eric
In Reply to: Re: [gentoo-dev] Release: metadata.xml python module by David Stanek
1 On Mon, 28 Jun 2004 19:50:33 -0400
2 David Stanek <dstanek@×××××××.com> wrote:
3
4 > (Bear with me, I like lines under 80 characters)
5 Me too :)
6
7 > 1. instead of
8 > if __tags_.has_key(...) and __tags_[...] == "Yes":
9 > this makes that line much easier to read
10 > if __tags_.get(...) == "Yes"
11 I was wondering if there was another way of doing it. I originally had
12 it __tags_[...] == "Yes" but it threw an exception if the key didn't
13 exist. I figured that a get would also. This is much more readable.
14
15 > 2. using -1 as an index into an array gets the last element and is
16 > much easier to read than array[len(array)-1]
17 Never seen that before. Definitely useful. You learn something new
18 everyday.
19
20 > Eric I have emailed you separately my changes, if you like em keep
21 > em free of charge :-D If not then feel free to delete the email.
22 I've added the changes for the next release. Thanks for your input.
23
24
25 --
26 Eric Olinger
27
28 Public Key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xF90FBBC1
29 Key fingerprint: B678 9E22 1161 51CF 6664 7591 6767 5BDB F90F BBC1
30
31 Give a man a password, he'll log in for a day. Teach him to code, and he
32 will hack his way in...