1 |
On Tuesday 12 April 2005 02:20 pm, Maurice van der Pot wrote: |
2 |
> On Tue, Apr 12, 2005 at 01:52:05PM -0400, Mike Frysinger wrote: |
3 |
> > On Tuesday 12 April 2005 11:59 am, Maurice van der Pot wrote: |
4 |
> > > I have the following situation: |
5 |
> > > - a package (valgrind) that can be compiled with PIE and uses PIE |
6 |
> > > for some purpose or other if it is supported |
7 |
> > > - tests (make check) that cannot be compiled with PIE |
8 |
> > |
9 |
> > allowing user specified tests for `make check` doesnt really make much |
10 |
> > sense |
11 |
> |
12 |
> 'user specified tests'?? The tests are part of valgrind, they just can't |
13 |
> be compiled with PIE. |
14 |
|
15 |
err s/tests/CFLAGS/ |
16 |
|
17 |
> > and in fact it's probably a better idea to prevent user CFLAGS from being |
18 |
> > used during `make check` |
19 |
> |
20 |
> In theory, you're probably right. But would you really spend time on |
21 |
> disabling user CFLAGS for make check? |
22 |
|
23 |
why not ? you've just shown they break things |
24 |
src_test() { make check CFLAGS="" || die "make check failed" ; } |
25 |
|
26 |
> How many ebuilds are doing this right now anyway? |
27 |
|
28 |
how many ebuilds' src_test are sensitive user CFLAGS ? very few i'd say |
29 |
-mike |
30 |
-- |
31 |
gentoo-dev@g.o mailing list |