Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files
Date: Sun, 24 Feb 2019 09:04:42
Message-Id: 1550999071.734.6.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files by Matt Turner
1 On Sat, 2019-02-23 at 22:19 -0800, Matt Turner wrote:
2 > On Fri, Feb 22, 2019 at 8:30 PM desultory <desultory@g.o> wrote:
3 > >
4 > > On 02/20/19 02:36, Michał Górny wrote:
5 > > > On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote:
6 > > > > > > > > > On Wed, 20 Feb 2019, Matt Turner wrote:
7 > > > >
8 > > > >
9 > > > > > # Don't install libtool archives (even for modules)
10 > > > > > - prune_libtool_files --all
11 > > > > > + find "${D}" -name '*.la' -delete || die
12 > > > >
13 > > > > Maybe restrict removal to regular files, i.e. add "-type f"?
14 > > >
15 > > > I suppose you should have spoken up when people started adopting that
16 > > > 'find' line all over the place. Though I honestly doubt we're going to
17 > > > see many packages installing '*.la' non-files.
18 > > >
19 > >
20 > > Just so we are all clear here: your argument is that more fully correct
21 > > approaches should not be considered in the present and future because
22 > > less fully correct approaches were implemented in the past? And,
23 > > further, that since nothing matching a specific pattern happens to come
24 > > to your mind at he moment, such things do not exist? Perhaps dialing
25 > > back the rhetoric from 11 and considering feedback as an opportunity to
26 > > improve existing code is called for in this case, among others.
27 >
28 > I think you might be reading more into this than was intended.
29 >
30 > I read his email as lamenting that the horse has left the barn, so to
31 > speak. There are already hundreds of uses of find -name '*.la' -delete
32 > without -type f in the tree, probably in large part because
33 > ltprune.eclass suggests the form without it.
34 >
35 > Suggesting dialing down the rhetoric when it appears that you have
36 > overreacted is a bit humorous.
37 >
38
39 He simply decided to stalk me and issue ad hominem attacks whenever he
40 can. It's how professionals in Gentoo react to critique.
41
42 --
43 Best regards,
44 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies