Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: export compilers to environment instead of setting in toolchain file, bug 542530
Date: Fri, 04 Nov 2016 12:20:35
Message-Id: 20161104132016.5acae7f3@gentoo.org
In Reply to: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: export compilers to environment instead of setting in toolchain file, bug 542530 by Maciej Mrozowski
1 On Thu, 3 Nov 2016 00:52:17 +0100
2 Maciej Mrozowski <reavertm@×××××.com> wrote:
3
4 > From: Maciej Mrozowski <reavertm@g.o>
5 >
6 > ---
7 > eclass/cmake-utils.eclass | 6 +++---
8 > 1 file changed, 3 insertions(+), 3 deletions(-)
9 >
10 > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
11 > index 88d2163..23cc094 100644
12 > --- a/eclass/cmake-utils.eclass
13 > +++ b/eclass/cmake-utils.eclass
14 > @@ -525,13 +525,13 @@ enable_cmake-utils_src_configure() {
15 >
16 > local toolchain_file=${BUILD_DIR}/gentoo_toolchain.cmake
17 > cat > ${toolchain_file} <<- _EOF_ || die
18 > - SET (CMAKE_C_COMPILER $(tc-getCC))
19 > - SET (CMAKE_CXX_COMPILER $(tc-getCXX))
20 > - SET (CMAKE_Fortran_COMPILER $(tc-getFC))
21 > SET (CMAKE_AR $(type -P $(tc-getAR)) CACHE FILEPATH
22
23
24 Have you tested cross compiling ?
25 IIRC toolchain file is used *before* getting those vars from env and is
26 used to determine system & compiler type. Without this you get bugs like
27 #503216

Replies