[gentoo-dev] Re: [PATCH] kernel-2.eclass: Fix func name to comply with pms, deprecate, old with deadline

[Mike Pagano]

On 5/11/22 15:21, Mike Pagano wrote:
> According to PMS certain words are reserved for package manager use and
> may not be used or
> relied upon by ebuilds.
>
> See: https://projects.gentoo.org/pms/8/pms.html#x1-13700012.3.17
>
>
> Bug: https://bugs.gentoo.org/843674
>
> Signed-off-by: Mike Pagano <mpagano@g.o>
> ---
>   eclass/kernel-2.eclass | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> index 02c70422ee0..b3fb5cef76c 100644
> --- a/eclass/kernel-2.eclass
> +++ b/eclass/kernel-2.eclass
> @@ -1411,7 +1411,16 @@ kernel-2_src_unpack() {
>
>       # allow ebuilds to massage the source tree after patching but before
>       # we run misc `make` functions below
> -    [[ $(type -t kernel-2_hook_premake) == "function" ]] &&
> kernel-2_hook_premake
> +    if [[ $(type -t kernel-2_hook_premake) == "function" ]]; then
> +        ewarn "The function name: kernel-2_hook_premake is being
> deprecated and"
> +        ewarn "being changed to:  kernel-2_insert_premake to comply
> with pms policy."
> +        ewarn "See bug #843686 "
> +        ewarn "The call to the old function name will be removed on or
> about July 1st, 2022 "
> +        ewarn "Please update your ebuild before this date."
> +        kernel-2_hook_premake
> +    else
> +        [[ $(type -t kernel-2_insert_premake) == "function" ]] &&
> kernel-2_insert_premake
> +    fi
>
>       debug-print "Doing unpack_set_extraversion"
>


Committed