Gentoo Archives: gentoo-dev

From: Ionen Wolkens <ionen@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] [PATCH 0/2] Add esed.eclass for sed that dies if caused no changes
Date: Tue, 31 May 2022 11:23:45
Message-Id: 20220531112319.29168-1-ionen@gentoo.org
1 Often preferable to use patches so this happens, but sed have its
2 uses/convenience and this intend to help reduce the amount of old
3 broken seds causing issues that go unnoticed on bumps.
4
5 Inspired by app-portage/iwdevtools' qa-sed (warns on any seds), but
6 this is for more deterministic use in ebuilds.
7
8 Also slightly shortens sed use, -i is default, and no need to || die.
9 (see @EXAMPLE in eclass for a quick usage overview).
10
11 Implementation / available wrappers / usefulness still up for debate,
12 but without further comments I consider this ready (albeit first time
13 touching / making an eclass, so I could be overlooking simple things).
14 Also partly uses >=bash-4.4, so EAPI-7 is not considered.
15
16 See github PR[1] for old changelog background.
17
18 Up to maintainers but personally would encourage to slowly replace
19 (almost) all use of sed with either this or patches. Some cases
20 where it can be inconvenient like eclasses "guessing" that a package
21 may or may not have something to replace, and that nothing happened
22 is not an issue.
23
24 [1] https://github.com/gentoo/gentoo/pull/25662
25
26 Ionen Wolkens (2):
27 esed.eclass: new eclass
28 eclass/tests/esed.sh: basic tests for esed.eclass
29
30 eclass/esed.eclass | 199 +++++++++++++++++++++++++++++++++++++++++++
31 eclass/tests/esed.sh | 173 +++++++++++++++++++++++++++++++++++++
32 2 files changed, 372 insertions(+)
33 create mode 100644 eclass/esed.eclass
34 create mode 100755 eclass/tests/esed.sh
35
36 --
37 2.35.1

Replies