Gentoo Archives: gentoo-dev

From: Florian Schmaus <flow@g.o>
To: "Maciej Barć" <xgqt@g.o>, gentoo-dev@l.g.o
Cc: Alfredo Tupone <tupone@g.o>, Sam James <sam@g.o>
Subject: Re: [gentoo-dev] [PATCH] eclass/dune.eclass: introduce edune and dune-compile (v2)
Date: Tue, 03 Jan 2023 15:10:09
Message-Id: 679cd0bd-09dc-c536-ec61-7f29875d0f5a@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] eclass/dune.eclass: introduce edune and dune-compile (v2) by "Maciej Barć"
1 On 03/01/2023 15.51, Maciej Barć wrote:
2 >> It appears there is additional output between the ebegin / eend. You
3 >> may want to consider dropping ebegin and eend. In general, the pattern
4 >> ebegin, edo, eend should probably be avoided.
5 >
6 > I would like to keep the "Building ... [ OK ]" (made by ebegin) output
7 > as it was before the change.
8
9 The reason the ebegin/edo/eend pattern should be avoided is that the
10 output will not be
11
12 Building ... [ OK ]
13
14 instead it will be
15
16 Building ... dune foo bar
17 [ OK ]
18
19 so the expectation that [ OK ] is on the right hand side is not fulfilled.
20
21 Note that edo.eclass also provides edob(), which can be used if it is
22 known that the command does not produce output.
23
24 For example
25
26 edob dune foo bar
27
28 should result in
29
30 Running dune foo bar [ OK ]
31
32 - Flow