Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst
Date: Thu, 15 Aug 2019 06:04:16
Message-Id: 312a51f2b7186f50f69ea533b2453dc7862c5001.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst by Mike Gilbert
On Wed, 2019-08-14 at 19:54 -0400, Mike Gilbert wrote:
> Closes: https://bugs.gentoo.org/691478 > --- > eclass/acct-user.eclass | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass > index 60009643c144..077f85417ce8 100644 > --- a/eclass/acct-user.eclass > +++ b/eclass/acct-user.eclass > @@ -334,8 +334,12 @@ acct-user_pkg_preinst() { > if [[ -z ${ACCT_USER_HOME_OWNER} ]]; then > ACCT_USER_HOME_OWNER=${ACCT_USER_NAME}:${ACCT_USER_GROUPS[0]} > fi > - fowners "${ACCT_USER_HOME_OWNER}" "${ACCT_USER_HOME}" > - fperms "${ACCT_USER_HOME_PERMS}" "${ACCT_USER_HOME}" > + # Path might be missing due to INSTALL_MASK, etc. > + # https://bugs.gentoo.org/691478 > + if [[ -e "${ED}/${ACCT_USER_HOME#/}" ]]; then > + fowners "${ACCT_USER_HOME_OWNER}" "${ACCT_USER_HOME}" > + fperms "${ACCT_USER_HOME_PERMS}" "${ACCT_USER_HOME}" > + fi > fi > } >
LGTM. -- Best regards, Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature