| 1 |
On 23/04/13 13:24, vivo75@×××××.com wrote: |
| 2 |
> On 04/22/13 13:03, Tobias Klausmann wrote: |
| 3 |
>> Hi! |
| 4 |
>> |
| 5 |
>> Since we probably will have to fix the files coming out of |
| 6 |
>> tarballs until the various upstreams have fixed them, I propose |
| 7 |
>> running a PNG fixer during or after the install phase. Since |
| 8 |
>> having pngcrush as dep for everything is not exactly lightweight, |
| 9 |
>> I hacked together a PNG file fixer in pure(ish, see below) |
| 10 |
>> Python: |
| 11 |
> No please, this real should stay really far from any package manager. |
| 12 |
> There are only two sane options: |
| 13 |
> 1) fix libpng to be backward compatible |
| 14 |
> 2) fix the package, and re-package / add a package for broken images |
| 15 |
> |
| 16 |
> But please don't push on all our user systems something like this. |
| 17 |
|
| 18 |
I appericiate the work done by Tobias utmost too but I have to agree |
| 19 |
this is not something I want to see running automatically, or even |
| 20 |
from within ebuilds. |
| 21 |
|
| 22 |
Perhaps if upstream writes the minimalized C version with no |
| 23 |
dependencies (or with only libpng dependency), we could add custom |
| 24 |
fix_IDAT() function but even then I'd prefer we fix the packages instead |
| 25 |
for SRC_URI= |
| 26 |
|
| 27 |
Trying to push time for going through some of the packages at: |
| 28 |
https://bugs.gentoo.org/show_bug.cgi?id=466190#c12 |
| 29 |
|
| 30 |
But help is needed and I bet some maintainers don't want others messing |
| 31 |
with their packages in the first place. |
| 32 |
The fix is the mentioned script OR pngcrush with USE="-system-libs" and |
| 33 |
`pngcrush -fix -force` |
| 34 |
|
| 35 |
> |
| 36 |
>> |
| 37 |
>> http://git.schwarzvogel.de/?p=pngfixer;a=summary |
| 38 |
>> |
| 39 |
>> Feel free to send patches |
| 40 |
>> |
| 41 |
>> Note that all I wrote is the mind-numbingly simple pngfixer.py |
| 42 |
>> script. The rest of the Python code is excised from PIL |
| 43 |
>> (http://www.pythonware.com/products/pil/index.htm). I didn't have |
| 44 |
>> to change anything there. |
| 45 |
>> |
| 46 |
>> Also note that it is not _strictly_ pure Python I'm using: the |
| 47 |
>> PIL components use Python's zlib.so and therefore are subject to |
| 48 |
>> bugs in _that_ code. |
| 49 |
> |
| 50 |
> Thanks for taking the time to write this it could be useful for |
| 51 |
> developers, but hopefully not as initially intended ;-) |
| 52 |
|
| 53 |
+1+1+1 |
| 54 |
|
| 55 |
Thanks everyone, |
| 56 |
|
| 57 |
- Samuli |
Archives