1 |
Find attached v4 of the patch, with all of the proposed changes |
2 |
included. |
3 |
|
4 |
On Wed, Jul 13, 2022 at 09:24:25AM +0200, Ulrich Mueller wrote: |
5 |
> >>>>> On Wed, 13 Jul 2022, Robin H Johnson wrote: |
6 |
> |
7 |
> > On Wed, Jul 13, 2022 at 02:26:43AM +0200, Ulrich Mueller wrote: |
8 |
> >> The "natural person" part was lost in this change. It also doesn't |
9 |
> >> reappear in the added section below. I think we don't want any corporate |
10 |
> >> entities there (or at least that's what I had taken from the previous |
11 |
> >> "Sony" discussion). |
12 |
> > Will re-add to the name section. |
13 |
Clarified to exclude corporations. |
14 |
|
15 |
> > For this section, I had a further thought and feel this is cleaner: |
16 |
> > to the commit message as a separate line. The sign-off must contain |
17 |
> > -the committer's legal name as a natural person, i.e., the name that |
18 |
> > -would appear in a government issued document. |
19 |
> > +the contributor's name as discussed in the next section. |
20 |
> |
21 |
> Good point, and much better. (In fact, in the previous version I |
22 |
> wondered why "Name" would have a capital letter, until I realized that |
23 |
> it referred to the example above.) |
24 |
> |
25 |
> Also, with the new wording, you could say "contributor's name as a |
26 |
> natural person" here, and leave the next section alone. Just as a |
27 |
> suggestion, with no strong preference on my side. |
28 |
Done. |
29 |
|
30 |
> > The new text was substantially written by myself, with the great suggestion |
31 |
> > from kuzetsa, and then everybody else contributed good edits to it. |
32 |
> |
33 |
> So far we had followed the principle not to list authors in the |
34 |
> acknowledgements (which is worded "the authors would like to thank"). |
35 |
> If we start adding them for revision 1.2, then we'd have to add more |
36 |
> names to the existing list. |
37 |
How's the clarification now, making it clear those are the authors for |
38 |
version 1.2? |
39 |
|
40 |
> > If you're happy to not take extra acknowledgement that this was for Rev 1.2, |
41 |
> > I'll just tweak it to add kuzetsa to authors and ajak to thanks list. |
42 |
> Please do. CCing rich0 and antarus, are you happy with this? |
43 |
|
44 |
> |
45 |
> Another small point: Whitespace in the new section doesn't follow the |
46 |
> style in the rest of the GLEP, which uses two blank lines before and one |
47 |
> blank line after section headings, as well as two spaces at the end of |
48 |
> every sentence. (This is also what GLEP 2 says.) |
49 |
Fixed - the blank lines were inconsistent in multiple places, but the |
50 |
two spaces were correct. |
51 |
|
52 |
-- |
53 |
Robin Hugh Johnson |
54 |
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer |
55 |
E-Mail : robbat2@g.o |
56 |
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 |
57 |
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 |