Gentoo Archives: gentoo-dev

From: Markos Chandras <hwoarang@g.o>
To: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
Cc: Gentoo Development <gentoo-dev@l.g.o>, qa@g.o
Subject: Re: [gentoo-dev] Patch for python.eclass
Date: Sat, 23 Oct 2010 20:58:11
Message-Id: 20101023205742.GA27640@Eternity.halls.manchester.ac.uk
In Reply to: Re: [gentoo-dev] Patch for python.eclass by Arfrever Frehtes Taifersar Arahesis
1 On Sat, Oct 23, 2010 at 10:54:52PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
2 > Subpatch #11 adds temporary support for EAPI="0" in python_get_implementational_package() to work
3 > around a part of bug #340395.
4 > This subpatch is very small, so I'm planning to commit it with the rest of subpatches.
5 >
6 > --
7 > Arfrever Frehtes Taifersar Arahesis
8
9 > --- python.eclass
10 > +++ python.eclass
11 > @@ -1711,10 +1711,18 @@
12 > fi
13 > fi
14 >
15 > - if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
16 > - echo "dev-lang/python:${PYTHON_ABI}"
17 > - elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
18 > - echo "dev-java/jython:${PYTHON_ABI%-jython}"
19 > + if [[ "${EAPI:-0}" == "0" ]]; then
20 > + if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
21 > + echo "=dev-lang/python-${PYTHON_ABI}*"
22 > + elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
23 > + echo "=dev-java/jython-${PYTHON_ABI%-jython}*"
24 > + fi
25 > + else
26 > + if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
27 > + echo "dev-lang/python:${PYTHON_ABI}"
28 > + elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
29 > + echo "dev-java/jython:${PYTHON_ABI%-jython}"
30 > + fi
31 > fi
32 > }
33 >
34 Well, I found sometime today and looked at your patches. Even thought I
35 find it quite hard to familiarize myself with the *rather complex* python.eclass,
36 I think your patches are fine if I may say.
37
38 --
39 Markos Chandras (hwoarang)
40 Gentoo Linux Developer
41 Web: http://hwoarang.silverarrow.org
42 Key ID: 441AC410
43 Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410