Re: [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Fix font IUSE=nls handling

[Matt Turner]

On Thu, Oct 1, 2020 at 1:07 AM Ulrich Mueller <ulm@g.o> wrote:
>
> >>>>> On Thu, 01 Oct 2020, Matt Turner wrote:
>
> > -     [[ ${PN} = font-misc-misc || ${PN} = font-schumacher-misc || ${PN##*-} = 75dpi || ${PN##*-} = 100dpi || ${PN##*-} = cyrillic ]] && IUSE+=" nls"
> > +     case ${PN#font-} in
> > +     adobe-100dpi|adobe-utopia-100dpi|bh-100dpi|bh-lucidatypewriter-100dpi|\
> > +     adobe-75dpi |adobe-utopia-75dpi |bh-75dpi |bh-lucidatypewriter-75dpi|\
> > +     misc-misc|schumacher-misc)
> > +             IUSE+=" nls"
> > +             ;;
> > +     esac
>
> This looks like the kind of logic that would better be moved to ebuilds.
> Especially when it has just proven to be error prone.

Yeah, that seems like a good idea. In fact, that seems easier since
it's actually xorg-3_font_configure() that uses the presence of nls to
choose configure arguments. I think I can simply add IUSE="nls" to the
relevant packages and remove this code from the eclass.

Thanks for making me think through that again!