Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-fs/openafs: ChangeLog openafs-1.4.5_pre1.ebuild

[Bo Ørsted Andresen]

On Sunday 14 October 2007 10:39:53 Donnie Berkholz wrote:
> On 14:25 Sat 13 Oct     , Stefaan De Roeck (stefaan) wrote:
> > 1.1                  net-fs/openafs/openafs-1.4.5_pre1.ebuild
> >
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-fs/openafs/openafs-1.4.5_pre1.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-fs/openafs/openafs-1.4.5_pre1.ebuild?rev=1.1&content-type=text/plain
> >
> > PATCHDIR=${WORKDIR}/gentoo/patches/$(get_version_component_range 1-2)
> > CONFDIR=${WORKDIR}/gentoo/configs
> > SCRIPTDIR=${WORKDIR}/gentoo/scripts
>
> Repoman won't catch these, but they still need quotes.

Actually they don't in assignments like these. In the rest of the ebuild
${PATCHDIR}, ${CONFDIR} and ${SCRIPTDIR} need quotes though (the same applies
to variables such as ${oldafsconfdir}, ${newafsconfdir} etc.). This ebuild also
contains a lot of [ ... ] tests that should either be converted to [[ ... ]] or
have all variables inside them quoted.

-- 
Bo Andresen