Gentoo Archives: gentoo-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] New Eclasses: postgres and postgres-multi
Date: Sun, 24 Jan 2016 23:44:59
Message-Id: 56A561D7.8030708@gentoo.org
In Reply to: Re: [gentoo-dev] New Eclasses: postgres and postgres-multi by "Aaron W. Swenson"
1 On 01/24/2016 06:29 PM, Aaron W. Swenson wrote:
2 > Okay, provided that the new USE_EXPAND is okay for POSTGRES_TARGETS,
3 > attached are the eclasses that I'll commit to the tree.
4 >
5
6 > case ${EAPI:-0} in
7 > 0|1|2|3|4) die "postgres-multi.eclass requires EAPI 5 or higher" ;;
8 > *) ;;
9 > esac
10
11 Does this really work with EAPI=6? I didn't try, but it looks like it
12 would need an eapply_user somewhere in src_prepare. And, pedantry
13 warning, there's no such thing as "EAPI 5 or higher." The lawyers will
14 tell you to do something like this instead (stolen from git-r3):
15
16 case "${EAPI:-0}" in
17 5|6)
18 ;;
19 *)
20 die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
21 ;;
22 esac
23
24 That will require an edit for every new EAPI, but prevents weird crashes
25 from things like a missing eapply_user.

Replies

Subject Author
Re: [gentoo-dev] New Eclasses: postgres and postgres-multi "Aaron W. Swenson" <titanofold@g.o>