Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: python@g.o, "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl
Date: Sat, 20 May 2017 13:02:57
Message-Id: 20170520130238.27222-1-mgorny@gentoo.org
1 The function was (verbosely) deprecated in Dec 2014, and banned since
2 EAPI 6. It is no longer used by any ebuild in ::gentoo.
3 ---
4 eclass/python-r1.eclass | 35 -----------------------------------
5 1 file changed, 35 deletions(-)
6
7 diff --git a/eclass/python-r1.eclass b/eclass/python-r1.eclass
8 index 809dc5f2b8e5..5eaa802e06b9 100644
9 --- a/eclass/python-r1.eclass
10 +++ b/eclass/python-r1.eclass
11 @@ -555,41 +555,6 @@ python_foreach_impl() {
12 multibuild_foreach_variant _python_multibuild_wrapper "${@}"
13 }
14
15 -# @FUNCTION: python_parallel_foreach_impl
16 -# @USAGE: <command> [<args>...]
17 -# @DESCRIPTION:
18 -# Run the given command for each of the enabled Python implementations.
19 -# If additional parameters are passed, they will be passed through
20 -# to the command.
21 -#
22 -# The function will return 0 status if all invocations succeed.
23 -# Otherwise, the return code from first failing invocation will
24 -# be returned.
25 -#
26 -# For each command being run, EPYTHON, PYTHON and BUILD_DIR are set
27 -# locally, and the former two are exported to the command environment.
28 -#
29 -# This command used to be the parallel variant of python_foreach_impl.
30 -# However, the parallel run support has been removed to simplify
31 -# the eclasses and make them more predictable and therefore it is now
32 -# only a deprecated alias to python_foreach_impl.
33 -python_parallel_foreach_impl() {
34 - debug-print-function ${FUNCNAME} "${@}"
35 -
36 - [[ ${EAPI} == [45] ]] || die "${FUNCNAME} is banned in EAPI ${EAPI}"
37 -
38 - if [[ ! ${_PYTHON_PARALLEL_WARNED} ]]; then
39 - eqawarn "python_parallel_foreach_impl() is no longer meaningful. All runs"
40 - eqawarn "are non-parallel now. Please replace the call with python_foreach_impl."
41 -
42 - _PYTHON_PARALLEL_WARNED=1
43 - fi
44 -
45 - local MULTIBUILD_VARIANTS
46 - _python_obtain_impls
47 - multibuild_foreach_variant _python_multibuild_wrapper "${@}"
48 -}
49 -
50 # @FUNCTION: python_setup
51 # @USAGE: [<impl-pattern>...]
52 # @DESCRIPTION:
53 --
54 2.13.0

Replies