Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o, Pacho Ramos <pacho@g.o>
Subject: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Do not inherit eutils.
Date: Sat, 19 Dec 2015 18:24:36
Message-Id: 22133.41169.638073.889716@a1i15.kph.uni-mainz.de
In Reply to: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Do not inherit eutils. by "Michał Górny"
1 >>>>> On Sat, 19 Dec 2015, Michał Górny wrote:
2
3 >> + set -f # disable filename expansion in echo arguments
4 >> echo -e ${DOC_CONTENTS} | fold -s -w 70 \
5 >> | sed 's/[[:space:]]*$//' > "${T}"/README.gentoo
6
7 > Maybe I'm missing something but is there any reason not to quote
8 > "${DOC_CONTENTS}" instead of working around the results of not
9 > quoting it?
10
11 IIUC the intention of not quoting it is to normalise whitespace,
12 especially embedded newlines. Unfortunately, I don't see a good way to
13 do this differently. Adding another processing step after echo -e is
14 too late, because newlines expanded from \n must be kept.
15
16 Ulrich

Replies