Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable
Date: Sat, 21 May 2016 19:40:46
Message-Id: 20160521214029.0de752d7.mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable by Mike Gilbert
1 On Fri, 6 May 2016 09:25:50 -0400
2 Mike Gilbert <floppym@g.o> wrote:
3
4 > This was only necessary when we ran phases in parallel.
5 > Also, PMS says this variable should not be modified.
6 > ---
7 > eclass/distutils-r1.eclass | 6 ------
8 > 1 file changed, 6 deletions(-)
9 >
10 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
11 > index 7965e91..497bed5 100644
12 > --- a/eclass/distutils-r1.eclass
13 > +++ b/eclass/distutils-r1.eclass
14 > @@ -628,12 +628,6 @@ distutils-r1_run_phase() {
15 > # in the sys.path_importer_cache)
16 > mkdir -p "${BUILD_DIR}/lib" || die
17 >
18 > - # We need separate home for each implementation, for .pydistutils.cfg.
19 > - if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
20 > - local -x HOME=${HOME}/${EPYTHON}
21 > - mkdir -p "${HOME}" || die
22 > - fi
23 > -
24 > # Set up build environment, bug #513664.
25 > local -x AR=${AR} CC=${CC} CPP=${CPP} CXX=${CXX}
26 > tc-export AR CC CPP CXX
27
28 I have merged this one as well to have both distutils-r1 changes
29 in a single cache regen.
30
31 --
32 Best regards,
33 Michał Górny
34 <http://dev.gentoo.org/~mgorny/>