Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: gentoo-dev@l.g.o
Cc: fonts@g.o
Subject: Re: [gentoo-dev] [PATCH] font.eclass: Don't assign FONT_S in global scope, allow an array.
Date: Fri, 20 Mar 2020 15:54:50
Message-Id: ufte3owco@gentoo.org
In Reply to: [gentoo-dev] [PATCH] font.eclass: Don't assign FONT_S in global scope, allow an array. by "Ulrich Müller"
1 >>>>> On Fri, 14 Feb 2020, Ulrich Müller wrote:
2
3 > Accessing ${S} in global scope is not allowed by PMS, therefore remove
4 > the global variable assignment of FONT_S which uses it. Add a fallback
5 > to ${S} in font_src_install() instead.
6
7 > Allow FONT_S to be an array, if there are multiple directories.
8 > Support for whitespace-separated lists will be kept for some time,
9 > and a QA warning will be shown.
10
11 > Die if pushd or popd fails.
12
13 > Closes: https://bugs.gentoo.org/613108
14 > Closes: https://bugs.gentoo.org/709578
15 > Signed-off-by: Ulrich Müller <ulm@g.o>
16 > ---
17 > This will be committed in 60 days from now. The backwards compatibility
18 > code for whitespace-separated FONT_S will be removed in one year.
19
20 I have merged this already today, because conflicts in the media-fonts
21 category started accumulating.
22
23 > ***** ATTENTION OVERLAY USERS *****
24 > If your ebuilds currently output error messages like:
25 > /var/tmp/portage/media-fonts/foo/temp/environment: line 1036: pushd: /var/tmp/portage/media-fonts/foo/work/foo: No such file or directory
26 > /var/tmp/portage/media-fonts/foo/temp/environment: line 1043: popd: directory stack empty
27 > then in future these will be caught by the added "|| die" statements
28 > after pushd and popd. So make sure to fix such breakage before the
29 > updated eclass will be committed.

Attachments

File name MIME type
signature.asc application/pgp-signature