Gentoo Archives: gentoo-dev

From: "Justin Lecher (jlec)" <jlec@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()
Date: Sat, 28 Nov 2015 15:51:15
Message-Id: 5659CD63.2080000@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx() by Davide Pesavento
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 28/11/15 16:28, Davide Pesavento wrote:
5 >> else - nonfatal ${VIRTUALX_COMMAND} "$@" +
6 >> nonfatal "$@"
7 >
8 > Please take the opportunity to clean this up, possibly only in
9 > EAPI=6 if you don't want to risk breaking existing ebuilds. See bug
10 > 517976 for details.
11 >
12 >> retval=$?
13
14 The return value is recorded and gets evaluated correctly.
15
16 src_test() {
17 virtx false
18 }
19
20 results in
21
22 * Scanning for an open DISPLAY to start Xvfb ...
23 debug: virtx: XDISPLAY=1
24 debug: virtx: /usr/bin/Xvfb :1 -screen 0 1280x1024x24
25 * Starting Xvfb on $DISPLAY=1 ...
26 debug: virtx: emake "false"
27 * ERROR: app-misc/dummy-1::dummy failed (test phase):
28 * virtx: the emake failed.
29 *
30 * Call stack:
31 * ebuild.sh, line 133: Called src_test
32 * environment, line 2072: Called virtx 'false'
33 * environment, line 2700: Called die
34 * The specific snippet of code:
35 * [[ ${retval} -ne 0 ]] && die "${FUNCNAME}: the
36 ${VIRTUALX_COMMAND} failed.";
37 *
38
39 Am I missing something?
40 -----BEGIN PGP SIGNATURE-----
41 Version: GnuPG/MacGPG2 v2.0
42
43 iQJ8BAEBCgBmBQJWWc1jXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
44 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
45 OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiWGcQAK6VSEgzlaUaJ+AEC/I+M+Rz
46 uHOmaEE005MsTpUf8GoRY35fnMNkICES9QLZjaSjliBJ6H/WdGDGcqm7rg5yx0j5
47 v12vv3LMrFX2D/+2SkTurMlGj0gOz+F27ted/p9tmJJLf0KcbusPiJvmjybNjNH+
48 5ksLdZEdnAj1p9qmXfoJ8IlKHO82GUn2cNS9O0XFW9WhSzmOaE+WOp2hQtX0HzUE
49 Y6vcVjl5ZD+RDvc2+7oFptOQxGyEZdP43JikAEsfISHnjA4AtYHMLjIHvItaVdoD
50 8qbG5WAwp0fg1BwqNM6G9neAbknKeGIBLXNBx1QxVj3toz3j3QR88RB1nyovGNp2
51 7LZjEWYW9/jLpXVTLTg+vwsM6IgvehFdErlXEcWR/q/Gk5Q7C86o3oN4RPaQ93HV
52 ElxL24u/j1CW1mFzXTgKbM4rxlD8G/aROxiKAh5+66ywSrW1SRhpHSYJxriioco3
53 iwUyZmBtfCB40+DAHl3cX+yxQ/pKMiR7oN67fsx3F8LEalorcONq5w2e1d0bVbgs
54 EqdlUqxZKyI6fUK67+rI6Nd2ZBduUpm9mTvJHovPMQ3gK2hyRiE6FkhLf53aMR4S
55 9cmq1Bmqqw3KGTlIu45gKP6NxUr/+n1dg2LYpZF72eKKhPkNOO68YogKS073VEWc
56 DJGgOFCpJQIV+BLid0VF
57 =Nh/f
58 -----END PGP SIGNATURE-----

Replies