| 1 |
On Mittwoch, 11. August 2021 13:54:19 CEST Florian Schmaus wrote: |
| 2 |
> On 10/08/2021 10.31, Andreas Sturmlechner wrote: |
| 3 |
> > On Montag, 9. August 2021 20:32:07 CEST Florian Schmaus wrote: |
| 4 |
> >> +if ${_DEFINE_XDG_SRC_PREPARE}; then |
| 5 |
> > |
| 6 |
> > You don't need an extra variable for that: |
| 7 |
> > |
| 8 |
> > if [[ ${EAPI} == [567] ]]; then |
| 9 |
> |
| 10 |
> Thanks for the suggestion, but I prefer the current approach. |
| 11 |
> |
| 12 |
> It avoids that someone later drops support for EAPI 5 and forgets |
| 13 |
> adjusting all the cases where it is mentioned. I think your other |
| 14 |
> suggestion, that dropping EAPI 4 in xdg_src_prepare() when removing |
| 15 |
> support for EAPI 4 was forgotten, somehow reinforces my point. :) |
| 16 |
|
| 17 |
Not really. Having to search for EAPI in the code is obvious when cleaning up |
| 18 |
EAPI, and is standard across many eclasses. If you miss that, you could just |
| 19 |
as well have _DEFINE_XDG_SRC_PREPARE linger on below after cleaning up the |
| 20 |
initialisation. |
| 21 |
|
| 22 |
Regards |
Archives