1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA1 |
3 |
|
4 |
On 06/08/2012 04:24 PM, Michał Górny wrote: |
5 |
> On Fri, 08 Jun 2012 16:06:27 +0200 hasufell <hasufell@g.o> |
6 |
> wrote: |
7 |
> |
8 |
>> |
9 |
>> On 06/08/2012 03:55 PM, Michał Górny wrote: |
10 |
>>> On Fri, 08 Jun 2012 15:34:32 +0200 Is there a need for that? |
11 |
>> |
12 |
>> I don't know, do you? |
13 |
> |
14 |
> Estimated to three packages, two in gx86, one in betagarden. All of |
15 |
> them grabbing zipballs from github, so can be easily changed to |
16 |
> download tarballs instead. |
17 |
> |
18 |
> Do you see a reason why they should use zipballs which are larger |
19 |
> and require adding unzip to DEPEND rather than tarballs? The only |
20 |
> reason for that I can see is that they copy-pasted the 'download' |
21 |
> URI from somewhere where author posted only zipball link. |
22 |
|
23 |
a) gentoo supports zip and zip is available. |
24 |
Not supporting zip would need a comment or a conditional error. |
25 |
Neither is implemented in the current code. Then you can start telling |
26 |
users what they should use and what not. |
27 |
|
28 |
b) future proof |
29 |
|
30 |
c) less breakage, less confusion |
31 |
|
32 |
> |
33 |
>> This reduces the amount of archives the eclass can handle. |
34 |
>> Unless gentoo decides to drop zip support I don't see a reason to |
35 |
>> do that in an eclass too just for the sake of code-style. |
36 |
> |
37 |
> It's for a sake of code & work amount. And zip support in Gentoo is |
38 |
> not obligatory. You need to add unzip to your DEPEND yourself. |
39 |
> |
40 |
>> My previous implementation had no trouble with zipballs. So if |
41 |
>> you suggest a new implementation I would expect that to be |
42 |
>> better. |
43 |
> |
44 |
> Your previous implementation was against the KISS principle. |
45 |
> |
46 |
|
47 |
Your implementation breaks existing functionality. |
48 |
|
49 |
|
50 |
- -1 for this |
51 |
-----BEGIN PGP SIGNATURE----- |
52 |
Version: GnuPG v2.0.19 (GNU/Linux) |
53 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ |
54 |
|
55 |
iQEcBAEBAgAGBQJP0hJyAAoJEFpvPKfnPDWzl6MIALSHrIp5sunNpYZziXnWte2s |
56 |
zx8NZLzi8YjZpymrPDWIHhTPN4t84IxzQW0J9rzbiB5VvjgzYKhHrStDoSGgam5E |
57 |
uPtR5p34W/pkMO5oxiZXkgOYv4+NbnfvCN1qjuexevsf7AN7bmJwB12/IZOdfHhI |
58 |
Dt1SE5EI+Puj9ydHUMFe6ooDlkiM6gpyP6RkhEouXHy6+Ji1CqHjMjzD4NMa67Gs |
59 |
08IhIsQ3WatOATdRgnNjx/WOSiFio4hGnR8cPNfK5BH2OuuORcMCGoV8psrYGiXm |
60 |
/yRUW6a0msxzFLivyiCqnM+Hwar2oBzspwm2pHD7Pu1v0B8zOSkLW7cdzqiGQrQ= |
61 |
=3aNm |
62 |
-----END PGP SIGNATURE----- |