Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH systemd.eclass] Use local variables instead of subshelling for do*() and new*().
Date: Mon, 12 Nov 2012 20:35:26
Message-Id: 20121112203442.GE83592@gentoo.org
In Reply to: [gentoo-dev] [PATCH systemd.eclass] Use local variables instead of subshelling for do*() and new*(). by "Michał Górny"
1 On 12-11-2012 21:30:20 +0100, Michał Górny wrote:
2 > ---
3 > gx86/eclass/systemd.eclass | 28 ++++++++++++----------------
4 > 1 file changed, 12 insertions(+), 16 deletions(-)
5 >
6 > diff --git a/gx86/eclass/systemd.eclass b/gx86/eclass/systemd.eclass
7 > index 47e342b..bb1ec7f 100644
8 > --- a/gx86/eclass/systemd.eclass
9 > +++ b/gx86/eclass/systemd.eclass
10 > @@ -69,10 +69,9 @@ systemd_get_utildir() {
11 > systemd_dounit() {
12 > debug-print-function ${FUNCNAME} "${@}"
13 >
14 > - (
15 > - insinto "$(_systemd_get_unitdir)"
16 > - doins "${@}"
17 > - )
18 > + local INSDESTTREE
19 > + insinto "$(_systemd_get_unitdir)"
20 > + doins "${@}"
21
22 Isn't this a bit ugly and assuming knowledge that you better not?
23
24 Fabian
25
26 --
27 Fabian Groffen
28 Gentoo on a different level

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies