| 1 |
On Saturday 13 April 2013 10:44:20 Michał Górny wrote: |
| 2 |
> The edos2unix is quite useful when handling DOS-sourced packages. |
| 3 |
> But since it's a bash function, you can't reasonably use it from within |
| 4 |
> find invocation. And often you hit packages which are all flooded with |
| 5 |
> CRLFs that you need to convert. |
| 6 |
> |
| 7 |
> That's why I'm suggesting to make edos2unix recursive. The posted patch |
| 8 |
> changes the function to use find+sed for the substitution, passing given |
| 9 |
> paths as the 'path' arguments to find. |
| 10 |
> |
| 11 |
> Whenever files are passed, nothing changes for ebuilds. If a directory |
| 12 |
> is passed, find converts it recursively. The only potential breakage is |
| 13 |
> when a non-file was passed and something weird was expected of it. |
| 14 |
|
| 15 |
i'm ambivalent on requiring the -r flag, so this LGTM as is |
| 16 |
-mike |
Archives