| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Mike Gardiner wrote: |
| 5 |
| On Fri, 2004-11-12 at 16:07 +0900, Georgi Georgiev wrote: |
| 6 |
|> |
| 7 |
|>Shouldn't do*, in*, new* die on a failure? |
| 8 |
|> |
| 9 |
| I would concur, in what situations would we not want a do*, or new* to |
| 10 |
| not cause a build failure? Shouldn't functions always install something, |
| 11 |
| and not be used for any sort of 'if something exists, install it, or |
| 12 |
| else don't bother'? |
| 13 |
|
| 14 |
Firstly, new* shouldn't need to die since they just cp and call their do* |
| 15 |
counterpart, iirc. |
| 16 |
|
| 17 |
Yes, I agree that things should install something or die, not ignore it. |
| 18 |
However, IMO, it is considered better style to keep all that kind of stuff in |
| 19 |
one place (the ebuild), just like it's usually considered better to handle all |
| 20 |
signals and exit code in main() of a C/C++ app. |
| 21 |
|
| 22 |
Cheers |
| 23 |
- -- |
| 24 |
Please keep your hands off the secretary's reproducing equipment. |
| 25 |
|
| 26 |
Aaron Walker < ka0ttic@g.o > http://dev.gentoo.org/~ka0ttic/ |
| 27 |
Gentoo/BSD | cron | shell-tools http://butsugenjitemple.org/~ka0ttic/ |
| 28 |
|
| 29 |
-----BEGIN PGP SIGNATURE----- |
| 30 |
Version: GnuPG v1.2.6 (GNU/Linux) |
| 31 |
|
| 32 |
iD8DBQFBlKGNC3poscuANHARAsjuAJ98MBLfLmNmHcMIiuH9tAzXqVInLQCg3I71 |
| 33 |
YBOF3tCzsXUzX5/mjvgUgBk= |
| 34 |
=lKYO |
| 35 |
-----END PGP SIGNATURE----- |
| 36 |
|
| 37 |
-- |
| 38 |
gentoo-dev@g.o mailing list |
Archives