[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/axiom: ChangeLog axiom-200805.ebuild

[Donnie Berkholz]

On 14:37 Sat 12 Jul     , Markus Dittrich (markusle) wrote:
> 1.1                  sci-mathematics/axiom/axiom-200805.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-mathematics/axiom/axiom-200805.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-mathematics/axiom/axiom-200805.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	# lots of strict-aliasing badness
> 	append-flags -fno-strict-aliasing
>
> 	./configure || die "Failed to configure"

If econf works, could you add a comment saying so?

> 	# use gcl 2.6.7
> 	sed -e "s:GCLVERSION=gcl-2.6.8pre$:GCLVERSION=gcl-2.6.7:" \
> 		-i Makefile.pamphlet Makefile \
> 		|| die "Failed to select proper gcl"
>
> 	# fix libXpm.a location
> 	sed -e "s:X11R6/lib:$(get_libdir):g" -i Makefile.pamphlet \
> 		|| die "Failed to fix libXpm lib paths"
>
> 	# Let the fun begin...
> 	AXIOM="${S}"/mnt/linux emake -j1 || die

Is there an upstream bug failed about parallel builds?

> src_install() {
> 	make DESTDIR="${D}"/opt/axiom COMMAND="${D}"/opt/axiom/mnt/linux/bin/axiom install \
> 		|| die 'Failed to install Axiom!'

Use emake, please.

>
> 	mv "${D}"/opt/axiom/mnt/linux/* "${D}"/opt/axiom
> 	rm -fr "${D}"/opt/axiom/mnt

Might want `|| die` for both of those, and anything else that sucks if it fails.

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com