Gentoo Archives: gentoo-dev

From: Ian Stakenvicius <axs@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: toolchain-funcs.eclass patch to fix bug 432390
Date: Thu, 27 Sep 2012 18:40:57
Message-Id: 50649D5B.80901@gentoo.org
In Reply to: [gentoo-dev] RFC: toolchain-funcs.eclass patch to fix bug 432390 by Ian Stakenvicius
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 27/09/12 01:55 PM, Ian Stakenvicius wrote:
5 > Hey all -- it's been a month since 432390 was filed; and this bug
6 > is keeping lirc-0.9.0-r2 from going stable. If nobody objects
7 > within the next 24h or so, I'm going to apply the following patch
8 > to toolchain-funcs.eclass to fix the bug.
9 >
10 > The patch does not revert existing behaviour and only allows the
11 > function to work properly (or fail gracefully) when used outside
12 > of kernel-2.eclass.
13 >
14 > The patch changes tc-ninja_magic_to_arch() as follows:
15 >
16 > 1 - changes the use of $KV to the local $kv in all checks
17 >
18 > 2 - assigns kv=${KV:-$KV_FULL} (so that if called from
19 > kernel-2.eclass it will work as-is, but if not then it will use the
20 > value of KV_FULL from linux-info, the way its supposed to)
21 >
22 > 3 - dies, instead of returning an invalid value, when no kernel
23 > version is available.
24 >
25
26 The bug mentions it'd not be a problem to use a 'local
27 KV=${KV:-$KV_FULL}' , so that would reduce the size of the patch
28 significantly and I have no issues doing that instead.
29 -----BEGIN PGP SIGNATURE-----
30 Version: GnuPG v2.0.19 (GNU/Linux)
31
32 iF4EAREIAAYFAlBknVsACgkQ2ugaI38ACPAQeQEAu/PZ4Qk22XHXgc9ahai8I/3Y
33 kqrewQtYmSYc+ixVoBoA/Agy7u+gRUGBlNoVlGr8A6FEOwrhRe0A61y9sX/KLLv/
34 =LJpg
35 -----END PGP SIGNATURE-----

Replies