Archives
Archives
| From: | James Le Cuirot <chewi@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH v2] java-ant-2.eclass: Replace unnecessary evals with arrays | ||
| Date: | Sat, 25 Feb 2017 14:33:03 | ||
| Message-Id: | 20170225142654.2485fbb8@symphony.aura-online.co.uk | ||
| In Reply to: | [gentoo-dev] [PATCH v2] java-ant-2.eclass: Replace unnecessary evals with arrays by "Michał Górny" |
||
| 1 | On Wed, 22 Feb 2017 22:54:22 +0100 |
| 2 | Michał Górny <mgorny@g.o> wrote: |
| 3 | |
| 4 | > Replace the horrifying use of evals along with quoting to pass multiple |
| 5 | > filenames whitespace-safe with much simpler bash arrays. While at it, |
| 6 | > also simplify the find-read loop. |
| 7 | |
| 8 | I've given this a rough test. Some of the code paths are rarely used |
| 9 | and I suspect some are never used now but it looks good anyway. Please |
| 10 | go ahead. |
| 11 | |
| 12 | -- |
| 13 | James Le Cuirot (chewi) |
| 14 | Gentoo Linux Developer |