Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic.
Date: Mon, 10 Oct 2011 16:11:33
Message-Id: 20111010161049.GA4972@comet
In Reply to: Re: [gentoo-dev] [PATCH autotools-utils] Use elibtoolize from libtool.eclass to fix libtool magic. by "Michał Górny"
1 On 09:55 Mon 10 Oct , Michał Górny wrote:
2 > On Sun, 9 Oct 2011 21:08:43 -0500
3 > Donnie Berkholz <dberkholz@g.o> wrote:
4 > > On 10:21 Sun 09 Oct , Michał Górny wrote:
5 > > > We're calling it with '--patch-only' to avoid heavy changes to
6 > > > ebuilds. This should handle gracefully eautoreconfed packages and
7 > > > those not using libtool as well (in worst case, it should try to
8 > > > apply patches twice).
9 > >
10 > > What kind of testing have you done?
11 >
12 > Simple testing on a few packages of mine. If you have something
13 > specific in mind, please be more accurate.
14
15 It's probably better to test on other people's code, since your own will
16 always use eclass code in the way you imagine it being used. For changes
17 to popular eclasses like this, I'd go find a cross-section of 25+
18 packages written by a variety of people besides yourself (or just test
19 all 87 in the tree). Bonus points for those written by the most and
20 least experienced devs, who I'd expect to use things in more
21 unexpected/unlikely ways.
22
23 --
24 Thanks,
25 Donnie
26
27 Donnie Berkholz
28 Council Member / Sr. Developer
29 Gentoo Linux
30 Blog: http://dberkholz.com

Replies