[gentoo-dev] Re: gentoo-x86 commit in dev-cpp/gflags: metadata.xml Manifest gflags-0.7.ebuild ChangeLog

[Tiziano Müller]

Alec Warner (antarus) wrote:

> Index: gflags-0.7.ebuild
> ===================================================================
> # Copyright 1999-2008 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: /var/cvsroot/gentoo-x86/dev-cpp/gflags/gflags-0.7.ebuild,v 1.1
> # 2008/03/09 07:40:02 antarus Exp $
>
> inherit distutils
>
> DESCRIPTION="Google's C++ argument parsing library with python
> extensions." HOMEPAGE="http://code.google.com/p/google-gflags/"
> SRC_URI="ftp://foo.bar.com/${P}.tar.gz"
> LICENSE="BSD"
> SLOT="0"
> KEYWORDS="~amd64"
> IUSE="python"
>
> DEPEND=""
> RDEPEND="${DEPEND}"
>
> src_compile() {
> econf || die "econf failed"
> emake || die "emake failed"
> }
Please add a
if use python; then
    distutils_src_compile
fi

>
> src_install() {
> emake DESTDIR="${D}" install || die "emake install failed"
> if use python;
> then
> cd python
> distutils_src_install
> fi
> }

The google-packages install everything in /usr/share/doc/${PF}. This also
includes COPYING and INSTALL as well as html-files.
You'll have to install the docs manually (check sparsehash, has the same
problem).

And you depend on python unconditionally. Rather use the python.eclass and
the "Optimize/cleanup idiom" from
http://www.gentoo.org/proj/en/Python/developersguide.xml

Cheers.

-- 
gentoo-dev@l.g.o mailing list