Gentoo Archives: gentoo-dev

From: Rolf Eike Beer <eike@×××××××.de>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/3] qmail.eclass: remove magic to query root group
Date: Fri, 13 Aug 2021 10:31:27
Message-Id: 2211150.ElGaqSPkdT@eto.sf-tec.de
In Reply to: Re: [gentoo-dev] [PATCH 2/3] qmail.eclass: remove magic to query root group by Ulrich Mueller
1 Am Freitag, 13. August 2021, 11:06:09 CEST schrieb Ulrich Mueller:
2 > >>>>> On Fri, 13 Aug 2021, Rolf Eike Beer wrote:
3 > > Am Donnerstag, 12. August 2021, 19:39:08 CEST schrieb Michael Orlitzky:
4 > >> On Thu, 2021-08-12 at 17:22 +0200, Rolf Eike Beer wrote:
5 > >> > The default owner is root:root anyway.
6 > >>
7 > >> This is only true of you don't call insopts earlier with some other
8 > >> value. I see "insopts -o root -g qmail -m 700" in there so you might
9 > >> want to double check.
10 > >
11 > > Not my day.
12 > >
13 > > Ok, given that there are several places that change users and groups
14 > > and the subfunctions are not always called it would be very few places
15 > > where I can remove the root:root (about 3) and be sure that everything
16 > > works. For that reason I would just keep them all and go back to the
17 > > initial patch 2.
18 >
19 > I believe the method of choice would be to execute the offending
20 > insopts/doins pair in a subshell, i.e. put a ( ) pair around them.
21
22 I will just do it the other way: explicitly reset it to defaults in the 2
23 functions that actually set something special.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies