[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/baselayout: baselayout-2.0.0_rc4-r1.ebuild

[Mike Frysinger]

On Wednesday 26 September 2007, Robin H. Johnson wrote:
> On Wed, Sep 26, 2007 at 06:41:50AM +0000, Mike Frysinger (vapier) wrote:
> > -	if [[ -f "${ROOT}/etc/conf.d/$1" ]]; then
> > +	if [[ -f ${ROOT}/etc/conf.d/$1 ]]; then
>
> You removed the quotes here - $ROOT with spaces?

same as your other comments, irrelevant ... [[ ]] handles things properly

> > -	for f in ${ROOT}etc/init.d/net.*; do
> > -		[[ -L ${f} || ${f} == "${ROOT}etc/init.d/${lo}" ]] && continue
> > +	for f in "${ROOT}"etc/init.d/net.*; do
> > +		[[ -L ${f} || ${f} == */${lo} ]] && continue
>
> Again the quotes, and that conditional looks iffy, it was checking
> against ${ROOT}/etc/init.d/net.lo before, and now it's checking against
> ${PWD}/*/net.lo?

where do you see $PWD ?  i see a simple string match
-mike