Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/4] desktop.eclass: domenu, fix dying on non-existing files
Date: Thu, 26 Jul 2018 17:43:12
Message-Id: CAJ0EP41FYVZ45dANX0NEWYcNEHHD_9cyZvE7kjjqKA+vTbt3hQ@mail.gmail.com
In Reply to: [gentoo-dev] [PATCH 1/4] desktop.eclass: domenu, fix dying on non-existing files by "Michał Górny"
1 On Thu, Jul 26, 2018 at 7:35 AM Michał Górny <mgorny@g.o> wrote:
2 >
3 > The weird logic in domenu had an explicit separate clause
4 > for unsuccessful return on non-existing files. This worked fine before
5 > EAPI 4 since '|| die' was mandatory. However, since 'doins' started
6 > dying on its own, developers have assumed the same for 'domenu'
7 > and stopped checking the exit status. As a result, missing files
8 > are now silently ignored.
9 >
10 > Change the logic to explicitly die when the file does not exist.
11 > To provide the best interoperability and avoid code duplication, just
12 > let 'doins' die on its own.
13
14 This patch series looks good to me.