Gentoo Archives: gentoo-dev

From: Mike <mpagano@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v3] kernel-2.eclass: Respect portage toolchain variables
Date: Tue, 04 Jan 2022 23:31:32
Message-Id: a7843316-09c2-430b-d192-de4818e0e3f0@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH v3] kernel-2.eclass: Respect portage toolchain variables by Sam James
1 On 1/4/22 18:25, Sam James wrote:
2 >
3 >
4 >> On 3 Jan 2022, at 18:23, Mike Gilbert <floppym@g.o
5 >> <mailto:floppym@g.o>> wrote: On Mon, Jan 3, 2022 at 12:49
6 >> PM Adrian Ratiu <adrian.ratiu@×××××××××.com
7 >> <mailto:adrian.ratiu@×××××××××.com>> wrote:
8 >>>
9 >>> Starting with kernel>=v5.7 the build system can override the
10 >>> tools vars by setting LLVM=1 [1], but older kernels still use
11 >>> the default GNU tools, so to be able to use a full LLVM/Clang
12 >>> build, CC & co should be set to their respective portage values.
13 >>>
14 >>> [1] a0d1c951ef08 kbuild: support LLVM=1 to switch the default
15 >>> tools to Clang/LLVM
16 >>>
17 >>> Co-authored-by: Manoj Gupta <manojgupta@××××××××.org
18 >>> <mailto:manojgupta@××××××××.org>> Signed-off-by: Adrian Ratiu
19 >>> <adrian.ratiu@×××××××××.com <mailto:adrian.ratiu@×××××××××.com>>
20 >>> [snip]
21 >>
22 >> This seems ok to me, at least given the way the eclass currently
23 >> works.
24 >>
25 >> At some point, we should really convert xmakeopts into an array.
26 >> Any of these variables might contain spaces, and that would break
27 >> the current implementation.
28 >
29 > agreed, but lgtm
30
31
32 Thanks to both authors for your work, this has been committed.
33
34 --
35 Mike Pagano
36 Gentoo Developer - Kernel Project
37 Gentoo Sources - Lead
38 E-Mail : mpagano@g.o
39 GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137
40 Public Key : http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index