Gentoo Archives: gentoo-dev

From: Ian Stakenvicius <axs@g.o>
To: Alexis Ballier <aballier@g.o>
Cc: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog toolchain-funcs.eclass
Date: Tue, 06 Nov 2012 13:13:03
Message-Id: 50990C90.5090705@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog toolchain-funcs.eclass by Alexis Ballier
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 06/11/12 06:57 AM, Alexis Ballier wrote:
5 > Hi,
6 >
7 > [...]
8 >> --- ChangeLog 27 Sep 2012 22:42:48 -0000 1.417 +++ ChangeLog 28
9 >> Sep 2012 15:07:30 -0000 1.418 @@ -1,6 +1,11 @@ # ChangeLog for
10 >> eclass directory # Copyright 1999-2012 Gentoo Foundation;
11 >> Distributed under the GPL v2 -# $Header:
12 >> /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.417 2012/09/27
13 >> 22:42:48 floppym Exp $ +# $Header:
14 >> /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.418 2012/09/28
15 >> 15:07:30 axs Exp $ + + 28 Sep 2012; Ian Stakenvicius
16 >> <axs@g.o> toolchain-funcs.eclass: + reverted fatal error
17 >> from unset and made it a warning only shown when + checking for
18 >> 'kern' arch, so that the portage environment call of tc-arch +
19 >> will not fail anymore, bug 436450
20 >>
21 >
22 > [...]
23 >
24 >
25 >> Index: toolchain-funcs.eclass
26 >> ===================================================================
27 >>
28 >>
29 RCS file: /var/cvsroot/gentoo-x86/eclass/toolchain-funcs.eclass,v
30 >> retrieving revision 1.118 retrieving revision 1.119 diff -u
31 >> -r1.118 -r1.119 --- toolchain-funcs.eclass 27 Sep 2012 19:34:28
32 >> -0000 1.118 +++ toolchain-funcs.eclass 28 Sep 2012 15:07:30 -0000
33 >> 1.119 @@ -1,6 +1,6 @@ # Copyright 1999-2012 Gentoo Foundation #
34 >> Distributed under the terms of the GNU General Public License v2
35 >> -# $Header:
36 >> /var/cvsroot/gentoo-x86/eclass/toolchain-funcs.eclass,v 1.118
37 >> 2012/09/27 19:34:28 axs Exp $ +# $Header:
38 >> /var/cvsroot/gentoo-x86/eclass/toolchain-funcs.eclass,v 1.119
39 >> 2012/09/28 15:07:30 axs Exp $ # @ECLASS: toolchain-funcs.eclass #
40 >> @MAINTAINER: @@ -358,7 +358,8 @@ [[ -z ${host} ]] &&
41 >> host=${CTARGET:-${CHOST}}
42 >>
43 >> local KV=${KV:-${KV_FULL}} - [[ -z ${KV} ]] && die
44 >> "toolchain-funcs.eclass: Kernel version could not be determined,
45 >> please inherit kernel-2 or linux-info" + [[ ${type} == "kern" ]]
46 >> && [[ -z ${KV} ]] && \ + ewarn "QA: Kernel version could not be
47 >> determined, please inherit kernel-2 or linux-info"
48 >
49 >
50 > I'm bored to see dozens of such warning whenever I install a
51 > package using tc-arch-kernel on freebsd; I'm going to remove this
52 > nonsensical warning until you find a better solution.
53 >
54 > A.
55
56
57 Sure -- note, though, that if $type == "kern" and $KV is unset, then
58 this function does *NOT* return valid values. It might be worthwhile
59 looking up why $type == "kern" on these packages if it doesn't need to
60 be...? Or providing some other exclusion for *BSD?
61
62 (i must admit my ignorance on *BSD, i have no idea what it uses for a
63 kernel and am assuming it's not a standard linux one)
64
65
66
67 -----BEGIN PGP SIGNATURE-----
68 Version: GnuPG v2.0.19 (GNU/Linux)
69
70 iF4EAREIAAYFAlCZDJAACgkQ2ugaI38ACPB7dgEAwFNlC9nhdQ1U6iJgXa7OduMd
71 OChurvwRJ+hAyfzBEugA/2lFRw71ZajHAOlU35lv0XLFaYqcO4tidrPikrCB3tFk
72 =zmYC
73 -----END PGP SIGNATURE-----

Replies