Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: Gentoo Dev <gentoo-dev@l.g.o>, Pacho Ramos <pacho@g.o>
Subject: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Use fixed location for README.gentoo
Date: Tue, 17 Aug 2021 04:53:38
Message-Id: upmuck6yh@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Use fixed location for README.gentoo by Mike Gilbert
1 >>>>> On Mon, 16 Aug 2021, Mike Gilbert wrote:
2
3 > On Sun, Aug 15, 2021 at 6:55 AM Ulrich Müller <ulm@g.o> wrote:
4 >> + ( # subshell to avoid pollution of calling environment
5 >> + docinto .
6 >> + dodoc "${T}"/README.gentoo
7 >> + )
8
9 > I believe the current handling "die" in subshells terminates execution
10 > at the end of the current phase.
11
12 > Maybe add "|| die" after the subshell so that execution stops
13 > immediately if dodoc fails.
14
15 Good catch. I think it's fine for current EAPIs, but for EAPI 6 we may
16 have a problem.
17
18 Patch v2 will follow.
19
20 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature