Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Florian Schmaus <flo@×××××××××.eu>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/3] rebar.eclass: fix @RETURN argument
Date: Mon, 12 Apr 2021 10:30:27
Message-Id: usg3v3idn@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/3] rebar.eclass: fix @RETURN argument by Florian Schmaus
1 >>>>> On Mon, 12 Apr 2021, Florian Schmaus wrote:
2
3 > -# @RETURN: full path with EPREFIX to a Erlang package/project on success,
4 > -# code 1 when dependency is not found and code 2 if multiple versions of
5 > -# dependency are found.
6 > +# @RETURN: full path with EPREFIX to Erlang package/project on success, code 1 when dependency is not found and code 2 if multiple versions of dependency are found.
7
8 I think the cure is worse than the disease here.
9
10 That @RETURN is supposed to be in one line means that it should be short
11 (otherwise it would be read as a paragraph). Any lenghty description
12 belongs in @DESCRIPTION instead.
13
14 Also, the "full path" is the function's output, not its return value.
15
16 So, suggestion:
17 # @RETURN: 0 success, 1 dependency not found, 2 multiple versions found
18
19 (and the rest can go into @DESCRIPTION).
20
21 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature