Gentoo Archives: gentoo-dev

From: "Robin H. Johnson" <robbat2@g.o>
To: gentoo-dev@l.g.o
Cc: Enrico Weigelt <weigelt@×××××.de>
Subject: Re: [gentoo-dev] epatch: reject patches with relative paths
Date: Fri, 31 Dec 2010 07:03:25
Message-Id: robbat2-20101231T065654-385765288Z@orbis-terrarum.net
In Reply to: Re: [gentoo-dev] epatch: reject patches with relative paths by Mike Frysinger
1 On Fri, Dec 31, 2010 at 12:17:26AM -0500, Mike Frysinger wrote:
2 > On Thursday, December 30, 2010 21:03:54 Enrico Weigelt wrote:
3 > > * Mike Frysinger <vapier@g.o> schrieb:
4 > > > On Thursday, December 30, 2010 20:05:01 Enrico Weigelt wrote:
5 > > > > IMHO, in longer terms, all patches should normalized, created w/
6 > > > > diff -ruN and applied w/ -p1. Thats how most people do it, so
7 > > > > a kind of semi-standard.
8 > > >
9 > > > not worth developer's time to force it since it poses no practical
10 > > > positive benefit to us
11 > >
12 > > It makes it easier for everyone who'll want to work on these
13 > > patches (eg. people besides the actual ebuild maintainers).
14 > >
15 > > BTW: I'm not proposing to rework all the patches right now,
16 > > just set a policy for new ones.
17 >
18 > suggestions are fine, but these arent a requirement we're going to force on
19 > developers. i already put together a list of suggestions for people long ago:
20 > http://dev.gentoo.org/~vapier/clean-patches
21 Nice document. Just two contradictory points that I've noticed been
22 useful:
23 1. Sometimes I've been given patches without information as to which
24 version they apply to. The timestamp on the --- line was critical to
25 tracing that, because it matched the source timestamp in the SCM.
26 2. The .orig suffix on the --- line has been very useful in seeing that
27 somebody accidentally reversed the patch when generating it.
28
29 One additional request: Using RFC822-style headers for patch text data.
30 Nice example in many of our MySQL patches, like this one:
31 ====
32 Gentoo-Bug: 238487
33 Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=238487
34 MySQL-Bug-URL: http://bugs.mysql.com/bug.php?id=39288
35 MySQL-Bug: 39288
36 MySQL-Lists-URL: http://lists.mysql.com/internals/35947
37 X-Patch-URL: http://bugs.gentoo.org/attachment.cgi?id=188019&action=view
38 Signed-off-by: Jorge Manuel B. S. Vicetto <jmbsvicetto@g.o>
39 Signed-off-by: Robin H. Johnson <robbat2@g.o>
40 Signed-off-by: Kristian Nielsen <knielsen@×××××××××××.org>
41 ====
42 The above taken from:
43 http://git.overlays.gentoo.org/gitweb/?p=proj/mysql-extras.git;a=blob_plain;f=02040_all_embedded-library-shared-maria-5.1.50.patch;hb=499f0f3c94f6d4dc1c46adafc622e9583ee6a315
44
45 --
46 Robin Hugh Johnson
47 Gentoo Linux: Developer, Trustee & Infrastructure Lead
48 E-Mail : robbat2@g.o
49 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85

Replies

Subject Author
Re: [gentoo-dev] epatch: reject patches with relative paths Mike Frysinger <vapier@g.o>