| 1 |
Dnia 28 listopada 2015 14:24:13 CET, Justin Lecher <jlec@g.o> napisał(a): |
| 2 |
>The main new feature is the introduction of virtx(). This function |
| 3 |
>executes |
| 4 |
>the arguments inside a Xfvb context in contrast to the deprecated |
| 5 |
>virtualmake which required to set VIRTUALX_COMMAND, which then gets |
| 6 |
>executed. |
| 7 |
> |
| 8 |
>Xemake and Xeconf should be converted to "virtx emake" and "virtx |
| 9 |
>econf", |
| 10 |
>respectively. |
| 11 |
> |
| 12 |
>Justin Lecher (8): |
| 13 |
> virtualx.eclass: Use case/esac to handle supported EAPIs |
| 14 |
> virtualx.eclass: Only source eclas once |
| 15 |
> virtualx.eclass: Use eqawarn instead of ewarn "QA:..." |
| 16 |
> virtualx.eclass: Ban deprecated functionality in EAPI > 5 |
| 17 |
> virtualx.eclass: Support EAPI=6 |
| 18 |
> virtualx.eclass: Whitespace cleanup |
| 19 |
> virtualx.eclass: Add missing die |
| 20 |
> virtualx.eclass: Simplify API into single virtx() |
| 21 |
> |
| 22 |
>eclass/virtualx.eclass | 87 |
| 23 |
>+++++++++++++++++++++++++++++++++++++------------- |
| 24 |
> 1 file changed, 65 insertions(+), 22 deletions(-) |
| 25 |
|
| 26 |
Generally looks good, though i would reorder the patches so they make more sense alone. Like add new API first, then deprecate old, then ban it all, then enable 6. |
| 27 |
-- |
| 28 |
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
Archives