1 |
On Fri, 11 Dec 2015 20:18:46 +0100 Gilles Dartiguelongue wrote: |
2 |
> Le vendredi 11 décembre 2015 à 12:17 +0000, Andrew Savchenko a écrit : |
3 |
> > commit: fcc5f0fe910ec73b41adf3120255571baf896d4c |
4 |
> > Author: Andrew Savchenko <bircoph <AT> gentoo <DOT> org> |
5 |
> > AuthorDate: Fri Dec 11 12:17:20 2015 +0000 |
6 |
> > Commit: Andrew Savchenko <bircoph <AT> gentoo <DOT> org> |
7 |
> > CommitDate: Fri Dec 11 12:17:20 2015 +0000 |
8 |
> > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcc5 |
9 |
> > f0fe |
10 |
> > |
11 |
> > dev-cpp/gtkglextmm: fix bug 552686 |
12 |
> > |
13 |
> > Fix underquoted aclocal definition. |
14 |
> > |
15 |
> > Package-Manager: portage-2.2.26 |
16 |
> > Signed-off-by: Andrew Savchenko <bircoph <AT> gentoo.org> |
17 |
> > |
18 |
> > .../files/gtkglextmm-1.2.0-aclocal.patch | 11 ++++++ |
19 |
> > dev-cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild | 46 |
20 |
> > ++++++++++++++++++++++ |
21 |
> > 2 files changed, 57 insertions(+) |
22 |
> > |
23 |
> > diff --git a/dev-cpp/gtkglextmm/files/gtkglextmm-1.2.0-aclocal.patch |
24 |
> > b/dev-cpp/gtkglextmm/files/gtkglextmm-1.2.0-aclocal.patch |
25 |
> > new file mode 100644 |
26 |
> > index 0000000..32fa489 |
27 |
> > --- /dev/null |
28 |
> > +++ b/dev-cpp/gtkglextmm/files/gtkglextmm-1.2.0-aclocal.patch |
29 |
> > @@ -0,0 +1,11 @@ |
30 |
> > +--- gtkglextmm-1.2.0/m4macros/gtkglextmm.m4.orig 2004-05-18 |
31 |
> > 10:29:34.000000000 +0400 |
32 |
> > ++++ gtkglextmm-1.2.0/m4macros/gtkglextmm.m4 2015-08-07 |
33 |
> > 17:02:42.324065008 +0300 |
34 |
> > +@@ -222,7 +222,7 @@ |
35 |
> > + dnl AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD([ACTION-IF-SUPPORTED [, |
36 |
> > ACTION-IF-NOT-SUPPORTED]]) |
37 |
> > + dnl Checks whether gtkglextmm supports multihead. |
38 |
> > + dnl |
39 |
> > +-AC_DEFUN(AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD, |
40 |
> > ++AC_DEFUN([AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD], |
41 |
> > + [ AC_LANG_SAVE |
42 |
> > + AC_LANG_CPLUSPLUS |
43 |
> > + AC_CACHE_CHECK([whether gtkglextmm supports multihead], |
44 |
> > |
45 |
> > diff --git a/dev-cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild b/dev- |
46 |
> > cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild |
47 |
> > new file mode 100644 |
48 |
> > index 0000000..504827e |
49 |
> > --- /dev/null |
50 |
> > +++ b/dev-cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild |
51 |
> > @@ -0,0 +1,46 @@ |
52 |
> > +# Copyright 1999-2015 Gentoo Foundation |
53 |
> > +# Distributed under the terms of the GNU General Public License v2 |
54 |
> > +# $Id$ |
55 |
> > + |
56 |
> > +EAPI=5 |
57 |
> > +GCONF_DEBUG="yes" |
58 |
> > + |
59 |
> > +inherit eutils gnome2 |
60 |
> > + |
61 |
> > +DESCRIPTION="C++ bindings for gtkglext" |
62 |
> > +HOMEPAGE="https://projects.gnome.org/gtkglext/" |
63 |
> > +SRC_URI="mirror://sourceforge/gtkglext/${P}.tar.bz2" |
64 |
> > + |
65 |
> > +KEYWORDS="~amd64 ~ppc ~x86" |
66 |
> > +IUSE="doc" |
67 |
> > +SLOT="1.0" |
68 |
> > +LICENSE="GPL-2 LGPL-2.1" |
69 |
> > + |
70 |
> > +RDEPEND=" |
71 |
> > + >=x11-libs/gtkglext-1 |
72 |
> > + >=dev-libs/libsigc++-2.0 |
73 |
> > + >=dev-cpp/glibmm-2.4:2 |
74 |
> > + >=dev-cpp/gtkmm-2.4:2.4 |
75 |
> > + virtual/opengl |
76 |
> > +" |
77 |
> > +DEPEND="${RDEPEND} |
78 |
> > + virtual/pkgconfig" |
79 |
> > + |
80 |
> > +src_prepare() { |
81 |
> > + # fix underquoted definition, bug 552686 |
82 |
> > + epatch "${FILESDIR}/${P}-aclocal.patch" |
83 |
> > + |
84 |
> > + # Remove docs from SUBDIRS so that docs are not installed, |
85 |
> > as |
86 |
> > + # we handle it in src_install. |
87 |
> > + sed -i -e 's|^\(SUBDIRS =.*\)docs\(.*\)|\1\2|' Makefile.in |
88 |
> > || \ |
89 |
> > + die "sed Makefile.in failed" |
90 |
> > + |
91 |
> > + gnome2_src_prepare |
92 |
> > +} |
93 |
> > + |
94 |
> > +src_install() { |
95 |
> > + gnome2_src_install |
96 |
> > + if use doc; then |
97 |
> > + dohtml -r docs/reference/html/* |
98 |
> > + fi |
99 |
> > +} |
100 |
> |
101 |
> Why a revbump for this, it appears to be a build-time fix only. |
102 |
|
103 |
Becase it fixes file installed on a live filesystem, which affects |
104 |
global aclocal runs. Without this fix each aclocal run in the |
105 |
system with this package installed aclocal warning will be |
106 |
displayed: |
107 |
|
108 |
/usr/share/aclocal/gtkglextmm-1.2.m4:225: warning: underquoted |
109 |
definition of |
110 |
AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD /usr/share/aclocal/gtkglextmm-1.2.m4:225: |
111 |
run info Automake 'Extending |
112 |
aclocal' /usr/share/aclocal/gtkglextmm-1.2.m4:225: or see |
113 |
http://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal |
114 |
|
115 |
> Also it |
116 |
> appears to be missing an autools inherit and eautoreconf call. |
117 |
|
118 |
No, it doesn't. This file is not used during gtkglextmm build, it |
119 |
is used by packages using gtkglextmm during their aclocal runs. |
120 |
|
121 |
Best regards, |
122 |
Andrew Savchenko |